Skip to content

feat(event-bus): support to make assertions on dispatched events when the event bus was not faked #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WendellAdriel wants to merge 1 commit into from
Closed

feat(event-bus): support to make assertions on dispatched events when the event bus was not faked #1530

WendellAdriel wants to merge 1 commit into from

Conversation

@WendellAdriel
Copy link
Contributor

@WendellAdriel WendellAdriel commented Aug 19, 2025 •
edited
Loading

Summary

  • TrackedEventBus: A new decorator class that records dispatched events while delegating to the real EventBus
  • Automatic Installation: EventBusTester now automatically wraps the EventBus with TrackedEventBus on construction
  • Dual Mode Support: The tester supports both tracked mode (handlers execute) and faked mode (handlers don't execute)
  • Backward Compatibility: Existing tests using preventEventHandling() continue to work as before
  • Merged Event Tracking: The EventBusTester now merges dispatched events from both TrackedEventBus and FakeEventBus, solving edge cases where components hold references to the old EventBus
  • Fixed assertDispatched() to properly fail when no events were dispatched

Fixes #1486

@WendellAdriel WendellAdriel changed the title feat(event-bus): support to make assertions on dispatched events even when the event bus was not faked feat(event-bus): support to make assertions on dispatched events when the event bus was not faked Aug 19, 2025
@WendellAdriel WendellAdriel mentioned this pull request Aug 19, 2025
Closed
2 tasks
@WendellAdriel
Copy link
Contributor Author

WendellAdriel commented Aug 19, 2025

@brendt I'm seeing that one test failed, but when I check, it's not related to these changes, and on my local this specific test that's marked as failed is passing. And to get weirder, it's the same one failing from #1529 😅

@brendt
Copy link
Member

brendt commented Aug 20, 2025

As discussed, let's clean these PRs up and tackle them one by one instead of all at the same time.

@brendt brendt closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Even bus tester improvements

2 participants

@WendellAdriel @brendt